Skip to content
Submitted 2 months ago

css html

Artem Rubchenko•60
@RubchenkoArtem
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Steven Stroud•11,890
    @StroudyPosted 2 months ago

    Hey great job getting it so close to the original, some things I noticed,

    • You have margin on your body, Its causing your body to not be centered, If you change it to margin-inline: auto that will center the body left and right.
    • ‍Using max-width: 100% or min-width: 100% is way more responsive then just width:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
    • You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
    • Another great resource for px to rem converter.
    • Line height is usually unitless instead of line-height: 150%; should use line-height: 1.5; this means it is 1.5 x the font-size, unitless value ensures that the line height will scale proportionately.
    • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
    • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
    • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.

    Nice to see you using CSS Variables, I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

    Marked as helpful
    0
  • Teodor Jenkler•3,740
    @TedJenklerPosted about 2 months ago

    Hi @RubchenkoArtem,

    Nice project! Here are a few suggestions:

    I noticed that there are too many containers (i.e., <div> elements). To simplify your layout, you can make the <body> a flex container with align-items: center and justify-content: center. Use one main card with flex-direction: column to stack all content without unnecessary nesting. This approach will greatly improve your SEO and accessibility, and also make your code more readable and maintainable, especially for larger projects. Additionally, you can use the <footer> element for the Frontend Mentor footer.

    Keep up the great work!

    Best, Teodor

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord