P
Steven Stroud• 4,160
@Stroudy
Posted
Hey great job getting it so close to the original, some things I noticed,
- You have margin on your body, Its causing your body to not be centered, If you change it to
margin-inline: autothat will center the body left and right. - Using
max-width: 100%ormin-width: 100%is way more responsive then justwidth:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail. - You should avoid using
pxas it is an absolute unit and not a responsive unit likeremorem, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels. - Another great resource for px to rem converter.
- Line height is usually unitless instead of
line-height: 150%;should useline-height: 1.5;this means it is 1.5 x the font-size, unitless value ensures that the line height will scale proportionately. - Setting a height and width attribute to your
<img>will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image, - You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
- Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
Nice to see you using CSS Variables, I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻
Marked as helpful
0
