Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @Katleho-codes, congratulations on your new solution!
1Improve your html markup using meaningful tags and replace the important blocks of content with better tags, for example the main div that takes all the content can be wrapped with
<main>or section, the cards you can be replaced the<div>that wraps each card with<article>you can wrap the paragraph with the quote with the tag<blockquote>this way you'll wrap each block of element with the best tag in this situation. Don’t usedivfor the important blocks, ever prefer some tag that shows what its containing the block.Here's a complete guide for HTML semantic TAGS: https://www.w3schools.com/TAgs/default.asp
2.Add the website favicon inserting the svg image inside the
<head>.<link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">3.Use units as
remoreminstead ofpxto improve your performance by resizing fonts between different screens and devices.To save your time you can code your whole page using
pxand then in the end use a VsCode plugin called px to rem here's the link → https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem✌️ I hope this helps you and happy coding!
Marked as helpful1@Katleho-codesPosted about 2 years ago@correlucas Thank you for this. I will definitely fix that
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord