CSS GRID

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Jose Rodriguez, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  The background wave image is missing and here’s the step-by-step to add it.First of all add the image as a background inside the body this is the code for that: background-image: url(../images/pattern-background-desktop.svg);

  Then you add background-repeat: no-repeat to avoid the background repeating and background-size: contain to make it fit full width and center with the card this is the best choice, but an alternative to resize it is to use background-size: 125%, Here’s the code with the modification and the image applied as background:

  body {
      background-size: contain;
      background-image: url(./images/pattern-background-desktop.svg);
      background-repeat: no-repeat;
      width: 100vw;
      height: 100vh;
      display: grid;
      place-content: center;
      background-color: hsl(225, 100%, 94%);
  }
  

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Jose Rodriguez (Mikey)•240

  @MikeyRG127Posted about 2 years ago

  @correlucas Thank you a lot brother!

  0
• 

  Kristina Radosavljevic•380

  @KristinaRadosavljevicPosted about 2 years ago

  Hi there,

  Just letting you know that your link to GitHub isn't working.

  As for the solution itself, what I noticed is that you're missing the hover effect on the Change link (it's supposed to turn purple and lose the underline). Also, I would probably add the cursor: pointer; property to all the clickable elements, I guess it's just good practice from the user experience perspective. Other than that, I think it looks pretty good :)

  Hope this helps and please fix the GitHub link so that people can look at your code and give you more in-depth feedback :)

  Marked as helpful

  0

  ---

  

  Jose Rodriguez (Mikey)•240

  @MikeyRG127Posted about 2 years ago

  @KristinaRadosavljevic Thank you very much for your feedback! <3

  1