CSS GRID Single Price Component

Community feedback

• 

  P

  Alper•1,010

  @adonmez04Posted almost 2 years ago

  Hi, @J-HernandezM. It's a good solution. Keep coding. I have some suggestions for you.

  1 - You don't need to give any class names to your main element. Because it should be a unique element on your page. You can just use it as the main.

  2 - You can use a section instead of div.card__join boxes. Section separates the main's content with h1-6 tags. We can access our content in the main with this style easily.

  3 - You don't need to use CSS Grid for 1 direction-flow. You can use flexbox for 1 direction-flow. CSS Grid works perfectly with 2 direction-flows and complex components. It usually uses a general page layout and 2 direction-flows. Actually in this challenge, you don't even need to use flexbox (for the container's child elements). You can give some whitespace to your elements with margin-bottom. It's an easy solution.

  4 - You should use the h1 tag on your page. This is necessary.

  5 - You can use ul > li instead of card__info whyInfo. It's another easy solution.

  Check some good solutions and implement to your code.

  I hope these will help you to improve your perspective. Keep coding. All the best.

  Marked as helpful

  0