CSS grid , pseudo selectors,

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Rafiza, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • remove z-index: -1 from .card--wrapper .img:hover::after, .card--wrapper .img:focus::after class to fix issues
  • another way is creating a div that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution
  • you can use article tag instead of a simple div to the container card for improve the Accessibility
  • img element must have an alt attribute, it's very important!
  • remove all margin from card--wrapper class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  0