css grid, padding, margin

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="content"> with the main tag and <div class="h2"> <p> with <h1> to make the content/page accessible. click here for more on web-accessibility and semantic html

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  To center .content on the page using flexbox, replace the height in the body with min-height: 100vh. There is no need to give the body a margin value

  Give h1 and p text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value and font-size of 15px which is 0.9375rem.

  For a responsive content,

  • Replace the width in .content with max-width and the height with a padding value for all the sides max-width: 320px which is 20rem/em padding:16px which is 1rem/em
  • Give the img a max-width of 100% and a border-radius value, the rest are not needed.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0
• 

  Don Delice Dushime•150

  @dondelice257Posted over 1 year ago

  You did it well, no more comments, keep improving your skills

  0