Design comparison
Solution retrospective
Identifying the required layout styling the borders.
What challenges did you encounter, and how did you overcome them?Identifying the exact spacing between elements and the font properties was challenging. Using the figma file i could figure out.
What specific areas of your project would you like help with?is the code efficient and readme file proffessional?
Community feedback
- @vgt3j4d4Posted about 2 months ago
-
Does the solution include semantic HTML? Yes, maybe
div.text
(div with the class text) can be switched to<article>
or<section>
. You might find this useful [HTML5 Element Flowchart].(https://html5doctor.com/downloads/h5d-sectioning-flowchart.png) -
Is it accessible, and what improvements could be made? Yes. Still I believe the
alt
property could add more context i.e.: QR code to visit Frontend Mentor and take your coding skills to the next level -
Does the layout look good on a range of screen sizes? Yes
-
Is the code well-structured, readable, and reusable? I believe the css could have been written in a separate file and include it as a
<link>
tag -
Does the solution differ considerably from the design? No
- What specific areas of your project would you like help with? > Is the code efficient and readme file proffessional?
The code is simple as I said above a separate .css file would help to separate the logic. Remember to remove the original
README.md
and renameREADME-template.md
toREADME.md
. TheBuilt With
section I believe needs to be updated.
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord