Skip to content
Submitted 7 months ago

CSS GRID, media querys

Adrian Reina Lobaina•200
@adrian-reina-391
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Testimonials grid section
  • HTML
  • CSS
2junior

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

First it looked excellent in the mobile view but in the PC view the design was broken so I had to start from scratch as I couldn't find the problem, I just did the right thing by not giving up

What challenges did you encounter, and how did you overcome them?

I did not understand why or how to ensure that in the PC view, the cards take up all the space that I assign to them in the grid, so I had to start with the PC view to do everything until I finished in the cell phone view.

What specific areas of your project would you like help with?

I would like to understand what needs to be done so that an element always occupies the entire area of its corresponding grid

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted 7 months ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have a suggestion regarding your code that I believe will be of great interest to you.

    MAKING ACCESSIBLE TESTIMONIALS :

    • Currently the Testimonials are not accessible because of using section element which has no semantic relations for testimonials, Actually we need to use <figure> and <blockquote> elements to wrap the testimonials.
    • For example:
    <figure>
  <figcaption>
    <img src="./assets/images/image-daniel.jpg" alt="Daniel Clifford" />
    <div>
      <p>
        <span class="sr-only">Testimony Author</span>
        Daniel Clifford
      </p>
      <p>Verified Graduate</p>
    </div>
  </figcaption>
  <blockquote>
    <h2>
      Testimonial Title 
      ... 
    </h2>
    <p>
       Testimonial Quote 
       ...
     </p>
  </blockquote>
</figure>
    • Additionally, you want to add proper alt for img inside testimonials instead of empty one alt="" because they are not for decoration, It will help us to tell the user who is the author of the testimonial, its recommended to use the author's name as the alt attribute value like alt="Daniel Clifford"
    • If you have any questions or need further clarification feel free to reach out to me.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    1
    Adrian Reina Lobaina•200
    @adrian-reina-391Posted 7 months ago

    @0xabdulkhalid Done, thanks for the suggestions

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord