Skip to content
Submitted about 3 years ago

CSS Grid Layout

Yeimy•365
@Yeimy7
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Room homepage
  • HTML
  • CSS
  • JS
3intermediate

Design comparison

SolutionDesign

Solution retrospective

Hi, this is my solution, feedbacks are very welcome!!

Community feedback

  • Malesela Kgobe•555
    @M-KgobePosted about 3 years ago

    My suggest are that:

    1. Try setting a min-height:100vh to your body element, and make all contet to fit without overflowing.
    2. I would also suggest using landmarks in your HTML document, check-out your report for more info.
    3. Increase the max-width of the @media to about 900px(personally this is usually my first media query then followed maybe by 600px then 400px/450px/475px), you have to use those devTools.
    4. Explore a bit of transitions.

    other than that, the layout seems pretty good. and the slider works fine

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord