Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I am proud of the fact that i am getting comfortable using CSS grid. i am really proud of that, i tried using the mobile first design technique and i prefer that next time i would try to make use of Sass technique.
What challenges did you encounter, and how did you overcome them?Nothing much.
What specific areas of your project would you like help with?well, i am still learning and practicing my efficiency with grid layout.
Community feedback
- @DarkstarXDDPosted 2 months ago
Looks nice. Some feedback.
- Heading levels should go in order. If you used a
h3
for the name, you shouldn't be using ah1
for the testimonial text that comes after the name. - You should not have multiple
h1
elements in a web page.h1
is usually the top most heading that describes the content of the page. In this design you actually don't have ah1
. But you can create a visually-hidden element and give that ah1
if you want. - Looking at how you have used the heading levels, i feel like you are deciding the heading level based on how they are styled in the design. You should not be doing that. You should decide what elements to use based on their semantic meanings. Not styles. After that you can use CSS to style the headings however you want.
- I would use a
h2
for each name and then use<p>
elements for the testimonial text. I would also wrap the testimonial<p>
elements in a<blockquote>
element. - I think it would be better if you give the container a
max-width
inrem
, so that the grid items doesn't keep increasing in size on larger screens. - It's better to use
rem
for font-sizes, media queries andmax-width
. If the user changes their browser font size, text in your site won't respect that if the font-sizes are defined inpx
. If you have them inrem
, the text will scale accordingly with the user's preferred font size. I usually userem
for all values, not only fonts. But it's just preference.
Marked as helpful0@CelineJamesPosted 2 months agothanks, i will see to this changes@DarkstarXDD
1 - Heading levels should go in order. If you used a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord