CSS GRID, HTML FLEX-BOX

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Abdulquddus ibrahim! 👋

  I notice the link to the project repository is the link to your GitHub profile (https://github.com/Xclusive09). I would recommend changing the URL to the URL to the project repository (https://github.com/Xclusive09/Base-appreal-coming-soon-).

  With that being said, congratulations on completing this challenge! 🎉

  Some suggestions from me.

  • Changing the html (or the :root) font-size can cause huge accessibility implications for those users with different font sizes or zoom requirements. I recommend taking a look at these resources to learn more about the issues.
    • A blog post by Josh Comeau where he writes about the problem of the 62.5% trick (and more!).
    • A comment from an accessibility expert (Grace Snow) about it.
  • Alternative text for the logo should be the company name. Also, alternative text for images should not contain any words that are related to image (e.g. picture, photo, logo, icon, graphic, avatar, etc). It's already an image element so the screen reader will pronounce it as an image.
  • Avoid using JavaScript to add styling (unless you've no other option). JavaScript allows you to change the CSS code using the style property. But, to make debugging easier and improve code maintainability, it’s best to avoid it. Use CSS classes instead.

  That's it! I hope this helps. 😊

  Marked as helpful

  0