Greetings PPechmann
Well, my approach when coding is to deal with the HTML structure first but taking into considerations the general layout of the work at hand. That gives me a hint on which elements should be siblings as an example.
- the h1 heading element effects can be achieved by using css
mix-blend-modeon the h1 element itself, that is you do not need the extra spans that you used . Try a value ofmix-blend-mode: difference - click events should be associated with interactive elements like the anchor and button element not an image. The arrow image is just decorative and should have been a child of the button with the click handler on the button. The image should not have a click handler.
- the anchor elements in the footer elements should have readable text for assistive technology users.
- the site has to be responsive , check from 376px onwards , i cannot view properly all the content and also take note that the sizes mentioned in the designs are by no means refer to media queries but are there to indicate what your site should look like at those given sizes.
Happy coding
Marked as helpful
@PPechmann
Posted
Hi @ChamuMutezva!
Thank you for taking the time to leave a very good feedback, I appreciate it.
Glad you mentioned the blend-mode, as I already doubted that the span approach would be the best.
I was aware of the responsiveness, but I decided to just finish the dimensions mentioned in the challenge as I do not learn much by just adjusting code through media queries and decided to save time and spend it with some additional learning :)
Thank you again and have a nice weekend :)
