Design comparison
Solution retrospective
Which areas of your code are you unsure of? grid, media queries Which areas of your code are you unsure of? media queries, image sizing
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hi John, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
I noticed that you used a
button
in which case the best option would be ana
, because in my head when a person clicks on a button written Read more, he is not confirming a form, or something like, it will be redirected to another page, to read more about!To resolve do this:
<a href="/">Read more</button>
To improve the code structure wrap this div:
<div class="attribution">
with the semantic tag
footer
The rest is great!
I hope it helps... 👍
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord