CSS Grid, Flexbox, Mobile-first approach

Community feedback

• 

  Bryan Li•3,530

  @Zy8712Posted about 1 year ago

  Your website looks great! The only slight modification I'd make is the bottom margins for the text of the "New" section when it is in its mobile format (right now the text is a bit squished). One other thing worth mentioning is that I feel like you should have <li></li> tags around your mobile menu icon:

       <div class="hamburger-menu-close-container">
         <img src="./assets/images/icon-menu-close.svg" alt="hamburger-close-icon">
       </div>
  

  Reason being is that screen readers have a specific way of announcing lists that only works if the list is properly structured. You can read more about it here.

  Besides that your solution is very solid. Good job! 👍

  1

  ---

  

  Julie_Gz•450

  @Julie-GzPosted 12 months ago

  @Zy8712 Thank you so much Bryan. I agree, the page does look strange on some screens, especially tablets and Ipads. I'll take your advice and try to improve my solution. Thanks again :)

  0