T
ApplePieGiraffe• 30,545
@ApplePieGiraffe
Posted
Hi, Giovani! 👋
Nice job on this challenge! 👏 You've done a nice job in positioning the background images in this challenge (something that can be a quite a tricky)! 😀
One or two very small things I'd like to suggest are,
- Decreasing the intensity of the box-shadow around the card component just a little (to match the original design).
- Perhaps using an
<article>tag for the card itself and including a heading inside it (which could be the name, maybe) to bump up the semantics of your HTML a bit. 😉
Keep coding (and happy coding, too)! 😁
1
Giovani• 90
@giovanibulian
Posted
Hey, @ApplePieGiraffe!
Thanks for the feedback! Positioning the background was a great challenge by itself, I gotta admit that. 😂
Regarding the box-shadow, I've changed the color to have an opacity of 0.5 and increased the blur radius.
And many thanks for the tips about the html semantics too. I've changed the <div> to the <article> tag as you suggested and used the <h2> tag for the name.
Happy coding! 😉
0
