CSS Grid, Flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  DECORATIVE SVG'S ♨️:

  • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.

  ---

  • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.

  ---

  • Since these images do not convey any important information or functionality, there is no need for an alt attribute.

  ---

  • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

  ---

  Example:

  <img src="images/decorative.svg" alt="">
  
  

  <img src="images\icon-supervisor.svg" alt="supervisor-icon">
  👇
  <img src="images\icon-supervisor.svg" alt="">
  
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Rohit Deshpande•870

  @rohitd99Posted over 1 year ago

  Hi Kenneth

  Congrats on completing the challenge.

  I noticed that your solution works on both mobile sizes that is width <= 375px and on desktop that is width >= 1440px. But on widths between 375px and 1440px there is no style as you've used media queries for the mobile and desktop. Generally we write the default style for either mobile or desktop and use media queries for the remaining one. So I'd suggest you use some style for the tablet, may just extend media query of mobile like media (max-width : 700px) or so for the tablet sizes too and have some styles for the width from 700 to 1440 or something.

  Other than that, you've used two h1 elements. For a page only a single h1 heading is sufficient for the title of the page , so you can combine them both into a single heading. Also I'd suggest using the article element for the cards instead of div since I feel they fit better in the given context semantically.

  Hope it helps , keep coding

  0