Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

CSS Grid, flexbox

Patrickโ€ข 800

@PPechmann

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Struggled a bit initally to get the whole thing centered (not sure where the error was), bit went back a few steps and managed. Overall very happy and learned some new things about grid.

Feedback is very welcome as always!

Community feedback

Lucas ๐Ÿ‘พโ€ข 104,420

@correlucas

Posted

๐Ÿ‘พHello Patrick, congratulations for your solution!

Your component is really good done and the grid system is perfect. There are two fine adjustments you can do to improve its design.

1.Give the container more max-width to have the proper size max-width: 1110px; and give more padding for each card to have more space between the card and its borders.

2.Improve the code semantics, replace the <div> that wraps each card with <article> and the paragraph with the quote with the property tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div> is only a block element without meaning.

Hope it helps and happy coding!

Marked as helpful

1

Patrickโ€ข 800

@PPechmann

Posted

@correlucas Hey Lucas, thank you very much for the feedback, it is very helpful and I will take it into consideration on future projects :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord