Css grid, flex, much padding and marging !!

Community feedback

• 

  Sam•230

  @samd1aPosted over 2 years ago

  Hi nelson, congrats on finishing the card it looks great!

  To make the page more accessible to search engines, change your <span class="weight-text"> to a <h1 class="weight-text"> and your <div class="lighter-text"> to a <p class="lighter-text">

  Also, I wouldn't recommend using CSS Grid for this project. Simply adding a margin-bottom on your .weight-text class would work better as the viewport width gets smaller, the card would expand vertically to fit all of the text in, which doesn't currently happen in this example.

  Hope this helps, happy coding!

  0

  ---

  

  nelson•160

  @HyoganPosted over 2 years ago

  @samd1a thank you for your help

  0
• 

  imad•3,330

  @imadvvPosted over 2 years ago

  Greetings nelson, Congratulations on completing this challenge!,

  you can use flex to easy center container on the middle of the page,and removing all the **margins** from container and apply this challenges to the body.

  body {
  	min-height: 100vh;
  	display: flex;
  	justify-content: center;
  	align-items: center;
  	font-size: 1rem;
  }
  

  over all you did well Happy coding and keep up the good work 👍

  0

  ---

  

  nelson•160

  @HyoganPosted over 2 years ago

  @imadbg01 thank you for your help

  0