CSS Grid, CSS Flexbox, Vue, SASS

Community feedback

• 

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted over 2 years ago

  Hey Victor! Congratulations on completing this great challenge. Your solution is pretty solid!😎 Here's a few tips and some suggestions to your inquiry:

  • Figuring out the css spaces/margins/paddings comes with some little experience. The more you practice is the more you figure out some general patterns and you also get more comfortable with css units like px, rem, em etc. So don't worry about this, just keep on practicing and also look at how other people write their code to be able to notice those common patterns and to borrow a few ideas. You did really well with this solution!
  • You might wanna use heading tags (<h2> - <h6> ) in your <article>. In your case, you have two options, you can use <div> instead of the <article> because the div doesn't require you to add heading tags or you can make the headings to your articles <h2> tags. This will clear all your HTML validation issues
  • In order to resolve some of your accessibility issues, you might wanna use landmarks in your html code, these help browsers easily navigate your code. So you might consider wrapping your divs in landmarks like <main> or <header> or <footer> you need to do this according to how your page is structured. Incase you want to know more about landmarks, follow this link.

  Happy coding and keep up the great work! 👍

  Marked as helpful

  1
• 

  Denis•1,060

  @Mod8124Posted over 2 years ago

  Hello, well done! If you just want to replicate or be closest to the original design, practice, practice a lot dude but you can use pixel-perfect tools usually they are extensions of the browser, I personally recommend: pixel-perfect

  Marked as helpful

  0