CSS Grid and srcset

Community feedback

• 

  TechNech•340

  @TechNechPosted over 2 years ago

  Hi, hope you are doing good. I checked out your work and I will say very good work and keep trying but I would like to point out a few of your issues:

  • In your CSS body, you are doing it the wrong way. You should remove display: grid and the rest of the grid properties. I would like you to try display: flex as it will make your life much more easier in aligning the content in the center of the page.

  • Also remove card-container class from the body element and wrap your contents from image-box till main-stats in it.

  • Instead of figure tag you should use picture tag for the hero image inside the card-container

  Cheers! Happy Coding!! :)

  1

  ---

  

  DSoluk•120

  @dsolukPosted over 2 years ago

  @TechNech thanks so much…made changes as suggested and makes so much more sense!!!

  0

  

  TechNech•340

  @TechNechPosted over 2 years ago

  @dsoluk Glad to hear and see the changes. I would further suggest you to:

  • Simplify the padding in your .main-copy to something like padding: 20px;

  • You are using picture tag for the hero-image, and it's causing the problem to align/grow with the container it's in, because by default it will show the mistake.jpg image you have chosen. I suggest you use a simple img tag wrapped in a div which will align it with the text side.

  Cheers!

  Marked as helpful

  0