CSS Grid & Flexbox Frontend Mentor QR Code Card

Hey there,

good work with the card! Looks pretty nice and close to the design.

An object-fit shouldn't be necessary at all for this challenge. All you need is a max-width for the box or the img. Rest should be good by itself.

BEM is very common, but there are some more methodologies. There are many approaches actually. You can find an article about that here: https://daverupert.com/2022/08/modern-alternatives-to-bem/

Finally, as for best practice, try to avoid px, but use rem/em whenever possible for more responsiveness + accessibility.

Bonus: A major resource for the accessibility: https://www.a11yproject.com/

Hope you find this feedback helpful!

Hey there... What's up?

My name is Luan Souza and I liked his work. But, I have something to add...

1. I recommend creating a separate CSS file where it may be possible to establish more readable semantics.
2. Try using display flex (justify-content and align-items) to center the card in the center of the image.

I hope I helped... See you later.