Css Grid and flex used for responsiveness

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Looks better, well done!

  Next you need to

  • fix line heights
  • soften shadow to match design
  • remove br from first paragraph
  • recommend making those h4s into h3s
  • changing this as it is invalid html structure: <span>$29</span> <h5> per month </h5>. Wrap the whole line in a paragraph and remove h5.

  You may want to bump all heading levels up tbh. Every page should have a h1. But this isnt really a whole Web page, so that's optional on this kind of challenge m n.

  0

  ---

  

  Lesley Kimutai•565

  @LeskimPosted over 3 years ago

  @grace-snow Ok, thanks

  0
• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Hello

  You need to use semantic html on this. Text should never be in a span alone. Use paragraph and a list

  I would also change the button for an anchor tag as that would trigger navigation on this solution, not perform an action.

  On mobile things look a bit squashed and off center for me. Its nearly there, but not quite right on mobile portrait or landscape. I'll add some Screenshots to slack for you.

  Good luck ☺

  0

  ---

  

  Lesley Kimutai•565

  @LeskimPosted over 3 years ago

  @grace-snow Thanks will do that ...Don't know why I use span that much ....Maybe it's the span of my knowledge😅 Thanks Grace

  0