CSS grid and DIY again :)

Community feedback

• 

  leverh•300

  @leverhPosted over 2 years ago

  Hey Yan, I think the whole thing looks great! As far as the grey goes, i used hsl(218, 22%, 67%) on mine. I use visual studio code which allows you to hover over the color you coded and then change it through the visualization of the color palette. Don't know if you can you it with scss though (that i noticed you're using).

  Marked as helpful

  0

  ---

  

  Yann•190

  @neuyannPosted over 2 years ago

  @leverh Thanks for your help. I'll change the color so. I dont use vscode to make frontendmentor challenges but rather codepen online coding. It's more convenient for me because I can keep on coding on different computers. thanks again :)

  1
• 

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted over 2 years ago

  Hey Yann, pretty solid solution you've got here! For the text color problem, sometimes you can improvise (the challenges encourage us to be creative!) but your text color is really okay! The main thing I'd like to point out is the responsiveness, here's a tip:

  • I noticed that you set a "margin" property to your grid-container in order to center it. You might want to instead style your <main> like this:

  main {
      height: 100vh;
      display: flex;
      justify-content: center;
      align-items: center;
  }
  

  this will center your "grid-container" within your <main> at any screen width and it won't break your responsiveness! Happy Coding!

  Marked as helpful

  0

  ---

  

  Yann•190

  @neuyannPosted over 2 years ago

  @tesla-ambassador Thanks for your advice. To be honest, im a bit lost when we speak about centering the main or div, it's quite confusing. But im starting to to understand it.

  Thanks for your time.

  1