CSS GRID AND CSS CUSTOM

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @MikeyRG127, great job on this project!

  Some suggestions to improve you code:

  • I noticed that you are using the <h1> heading for all your headings. Unfortunately, this an incorrect use of it. The **<h1> heading is used for the highest priority heading and can only be used once per page. For this challenge, its safer to use the <h2> heading because its the second highest priority and its reusable.

  • While having interactive content (cards, links, icons, buttons, etc…) can definitely make content less static, if not done properly, it can actually have negative effect on your users experience. By simply just applying a “hover” effect to your content, you’re assuming that every device is compatible with “hover” effects. Unfortunately, most devices are not. To provide your users a better experience, you can use the @media (hover: hover) . Now users that that are devices that are not “hover” compatible will be able to enjoy your content.

  Sources:

  https://css-tricks.com/solving-sticky-hover-states-with-media-hover-hover/

  https://youtu.be/uuluAyw9AI0

  • To make you content accessible to your users, it is a best to use rem/em instead of px for your CSS property values. For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.

  Sources:

  https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9

  https://uxdesign.cc/why-designers-should-move-from-px-to-rem-and-how-to-do-that-in-figma-c0ea23e07a15

  Happy Coding!

  0

  ---

  

  Jamie Wilson•140

  @dottereldesignPosted about 2 years ago

  @vcarames Dude, you give better feedback than my tutors at Uni, haha. I've never even heard of that hover fix for mobile devices. Really glad I clicked on this post!

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  @dottereldesign

  Glad I could help.

  I suggest checking out Kevin Powells' s YouTube channel https://www.youtube.com/kepowob.

  I learned a lot from his channel.

  0