CSS Grid

Community feedback

• 

  Matias Ludueña•1,990

  @matiasluduena23Posted about 1 year ago

  Hi Dalma! Congratulation you finished the challenge!!! It looks really good! Just one advice.

  1. to add a hover effect in you button , use button{ cursor:pointer ; transition: opacity 200ms ease-in-out }, and in you buttton:hover { opacity: 0.7; } you can play with this number. Here you have an example using the background-color.

  keep improving (;

  Good code!!!

  Matias

  Marked as helpful

  0

  ---

  

  NBD•240

  @bdal90Posted about 1 year ago

  Hey Matias,

  Thank you for your remark, to be honest, I didn't add any special effect because it wasn't in the task though I know it would look much better. ;)

  0
• 

  Bryan Li•3,530

  @Zy8712Posted about 1 year ago

  The desktop version of your site looks pretty good. The only main changes I'd make is the breaking point of your website and the choice of having a scroll bar inside your container. Right now there is an awkward in-between on the desktop version, where certain screen sizes are too small for the container to fit (causing everything inside your container to shift), but the screen isn't small enough for your website to change to the mobile format which would be better.

  Also to answer your question, your CSS is pretty minimal, so I wouldn't worry about it too much. Though one thing I'd remove is the redundant code I found in your style.css:

  .subscription__price {
      color: var;
  }
  

  Besides that your site is pretty solid. Great work 👍

  Marked as helpful

  0

  ---

  

  NBD•240

  @bdal90Posted about 1 year ago

  Hey Bryan,

  Thanks a lot for your remarks, you are right, I'll look into my media queries and I kind of thought the scrollbar is not very convenient either, I'll try to do something with that as well.

  Thanks,

  Dalma

  0