Skip to content
Submitted 4 months ago

CSS Grid

Nina•30
@NinaLiao
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

了解CSS Grid

What challenges did you encounter, and how did you overcome them?

google & claude

Community feedback

  • Boris•2,850
    @mkborisPosted 4 months ago

    Hi Nina your solution looks great, here are some suggestions that might interest you

    • All content should be wrapped within landmarks. Wrap a main tag around card.
    • You are missing a primary heading for your card which is the person's name, it should be an h1
    • The social links are supposed to be anchor a tags a styled liked buttons not p.
    • Font sizes should be in rem not px, this article explains it better Why font-size must NEVER be in pixels.
    • Media queries should be defined in rem or em not px.

    Hope this helps

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord