Design comparison
SolutionDesign
Community feedback
- @DreamCoder7Posted over 2 years ago
Hi, system-freshπ
Good effort on this challenge!π
Here are a few things I'd like to suggest,
- Perhaps using a little bit of semantic HTML help you with accessibility and much easier to read. like wrapping the hole code into
<section class="productbig">....</section>
because it's more sense to have it's own section. And also wrapping the testimonial part like this is also practical
<figure class="box"> <div class="profile"></div> <blockquote> <p>...</p> </blockquote> </figure>
- Instead of using the
<img src=".." alt=".."/>
to display the icon-star.svg you can use the cssbackground-image
to avoid the repetition you made on HTML.
background-image: url('..'); background-size: 20px 20px; background-repeat: repeat-x; background-repeat: space; ....
- You already set the
padding: 0;
and 'margin: 0;' using the universal selector (*
) to reset all the element means any style that you put in the body gets inherited you don't need to repeat into thebody{}
tag
Hope you find this helpful.π
Keep coding!π
0 - Perhaps using a little bit of semantic HTML help you with accessibility and much easier to read. like wrapping the hole code into
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord