Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

css grid

system-freshβ€’ 140

@System-Fresh

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Abreham Nigussieβ€’ 470

@DreamCoder7

Posted

Hi, system-freshπŸ‘‹

Good effort on this challenge!πŸ‘Œ

Here are a few things I'd like to suggest,

  • Perhaps using a little bit of semantic HTML help you with accessibility and much easier to read. like wrapping the hole code into <section class="productbig">....</section> because it's more sense to have it's own section. And also wrapping the testimonial part like this is also practical
<figure class="box">
        <div class="profile"></div> 
        <blockquote>
                   <p>...</p>
        </blockquote>
</figure>

Read more semantic HTML

  • Instead of using the <img src=".." alt=".."/> to display the icon-star.svg you can use the css background-image to avoid the repetition you made on HTML.
background-image: url('..');
background-size: 20px 20px;
background-repeat: repeat-x;
background-repeat: space;
....
  • You already set the padding: 0; and 'margin: 0;' using the universal selector (*) to reset all the element means any style that you put in the body gets inherited you don't need to repeat into the body{} tag

Hope you find this helpful.😊

Keep coding!😎

0

system-freshβ€’ 140

@System-Fresh

Posted

@redstorm-hub thank youπŸ‘

0
Abreham Nigussieβ€’ 470

@DreamCoder7

Posted

@System-Fresh

No problem!πŸ€—

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord