css grid

Community feedback

• 

  Abreham Nigussie•470

  @DreamCoder7Posted over 2 years ago

  Hi, system-fresh👋

  Good effort on this challenge!👌

  Here are a few things I'd like to suggest,

  • Perhaps using a little bit of semantic HTML help you with accessibility and much easier to read. like wrapping the hole code into <section class="productbig">....</section> because it's more sense to have it's own section. And also wrapping the testimonial part like this is also practical

  <figure class="box">
          <div class="profile"></div> 
          <blockquote>
                     <p>...</p>
          </blockquote>
  </figure>
  

  Read more semantic HTML

  • Instead of using the <img src=".." alt=".."/> to display the icon-star.svg you can use the css background-image to avoid the repetition you made on HTML.

  background-image: url('..');
  background-size: 20px 20px;
  background-repeat: repeat-x;
  background-repeat: space;
  ....
  

  • You already set the padding: 0; and 'margin: 0;' using the universal selector (*) to reset all the element means any style that you put in the body gets inherited you don't need to repeat into the body{} tag

  Hope you find this helpful.😊

  Keep coding!😎

  0

  ---

  

  system-fresh•160

  @System-FreshPosted over 2 years ago

  @redstorm-hub thank you👍

  0

  

  Abreham Nigussie•470

  @DreamCoder7Posted over 2 years ago

  @System-Fresh

  No problem!🤗

  0