Css Flexbox with div elements.

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

• I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

• This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

• So fix it by replacing the <div class="container flex"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

• What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

• They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

HEADINGS ⚠️:

• And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

• Every site must want at least one h1 element identifying and describing the main content of the page.

• An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

• So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

iMAGES 📸:

• Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute.

• The alt attribute should explain the purpose of the image.

• E.g. alt="QR code to frontendmentor.io"

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

You don't need to have height: 100vh for the container, in fact, avoid fixed height for text container elements.

Instead use grid or flexbox on the parent, in this case the body:

• body { font-family: 'Outfit', sans-serif; background-color: hsl(212, 45%, 89%); min-height: 100vh; display: grid; place-items: center; }

or

• body { font-family: 'Outfit', sans-serif; background-color: hsl(212, 45%, 89%); min-height: 100vh; display: flex; justify-content: center; align-items: center; }

notice the min-height:100vh, this ensures that it covers the entire screen so you have space to use for centering.

Hope you find this feedback helpful!

You can also use absolute positioning, top and left properties, and then a transform translate combination to center things, but it is a lot uglier than either flex or grid so I wouldn't recommend it.

Flex is a great way of centering things. But you can also do it using grid. You can use the following snippet. It takes only two lines. Shorter then flex. I prefer to center things this way.

display: grid;
place-items: center;