@Stroudy
Posted
All my previous feedback still applies to this challenge. I hesitate to continue providing feedback if it is not being well-received. However, I would like to add one point:
- Your
<ul> <li>
text should be wrapped with a<a>
so it is accessible with a keyboard using the tab key, Using an <a> tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a <button> not intended for links.
<ul>
<li>GitHub</li>
<li>Frontend Mentor</li>
<li>LinkedIn</li>
<li>Twitter</li>
<li>Instagram</li>
</ul>
I really do hope to see you onboard the previous feedback! Good Luck!
@aouintihouari
Posted
@Stroudy I sincerely appreciate you looking over my code and providing me with tips on how to improve my coding. I sincerely apologize for not implementing your advice; I was unaware of the notifications because I am new to this platform and did not see your comments before beginning the challenges. From now on, I will pay close attention to the advice of my peers.
@Stroudy
Posted
@aouintihouari, Thank you for your response, I completely understand, and I appreciate your willingness to take my feedback into consideration moving forward. We all have a learning curve when getting used to new platforms!
I’m glad to hear that you’re open to feedback from your peers, and I’m more than happy to continue providing any guidance that can help you improve. Keep up the good work on your challenges!