Css flex-box

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <section> with the main tag, <div class="attribution"> with the footer tag and <h2> with <h1> to make the content/page accessible. click here for more on web-accessibility and semantic html

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  There is no need to style the section, give its background-color to the body.

  To center .body on the page using flexbox,add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  There is no need to style .imagebox.

  For a responsive content,

  • Replace the width in .body with max-width and the height with a padding value for all the sides padding:16px which is 1rem/em
  • Give the img a max-width of 100% and a border-radius value, the rest are not needed.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Give .text-area a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Lord-Ace•80

  @lord-AcePosted over 1 year ago

  @Hassiai thanks a lot I'll take note next time

  0
• 

  Cristian Ariel Delgado•50

  @CristianArielDelgadoPosted over 1 year ago

  Great job!

  Keep working hard, believe in yourself!

  Happy codding.

  Marked as helpful

  0
• 

  steven•10

  @stevenestePosted over 1 year ago

  Esta muy bien solo te falto lograr entrar el texto dentro de la card

  0