Skip to content
Submitted 11 months ago

CSS Flexbox Solution

Scott Rogener•50
@scottyroges
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Couple of places I'm unsure of

  • I used height: 100vh in my body to get a page that wouldn't scroll and allow me to put my footer at the bottom. Is that right?
  • In :root I set my default font size so that I could us rem units. It's still unclear to me if I should use rem or pixel or when.

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,160
    @MelvinAguilarPosted 11 months ago

    Hello there 👋. Good job on completing the challenge !

    I have some suggestions about your code that might interest you.

    • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource 📘.
    • Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.
    • Maintain a clear heading hierarchy, starting with <h1> and progressing through heading levels. Source 📘
    • Add an alt attribute to the QR code image, explaining its purpose, e.g., QR code to frontendmentor.io.

    I hope you find it useful! 😄 Above all, the solution you submitted is great!

    Happy coding!

    Marked as helpful
    1
    Scott Rogener•50
    @scottyrogesPosted 11 months ago

    @MelvinAguilar Thank you for the tips!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord