Design comparison
Solution retrospective
The most challenging for me in this project is to get the purple filter on the picture. So thank to this challenge I am now familiar with the 'background-blend-mode' property in CSS.
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Gigi Lukacs, congratulations for your new solution!
I saw your preview site and I liked a lot the work you’ve done here, it's almost complete, I’ve some suggestions you can consider applying to your code:
You did a good work putting everything together in this challenge, something you can do to improve the image that needs to change between mobile and desktop is to use
<picture>
instead of<img>
wrapped in a div. Look that for SEO and search engine reasons isn’t a better practice import this product image with CSS since this will make harder to the image be found. You can manage both images inside the<picture>
tag and use the html to code to set when the images should change setting the devicemax-width
depending of the device (phone / computer) Here’s a guide about how to usepicture
:https://www.w3schools.com/tags/tag_picture.asp
✌️ I hope this helps you and happy coding!
1@GinverPosted about 2 years ago@correlucas Hi Lucas, thanks a lot for taking time to look at my solution. I indeed checked out the option you recommended. I did adjust my code and add it in my code as option 2. Regarding SEO I absolutely get the idea. However, this solution leaves a little inperfection under my images. If you have time pls take a look. I might have missed something. But anyhow I learnt a lot from this! So thanks again!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord