CSS flexbox responsive 3-column card preview

Community feedback

• 

  Eric Salvi•1,350

  @ericsalviPosted over 3 years ago

  Hey Nebiyou,

  Great job on completing your 2nd project. I didn't notice too many things off on the design itself. I would try on your next project to maybe include semantic HTML for your HTML markup, https://www.w3schools.com/html/html5_semantic_elements.asp and for your class names, try the BEM naming convention, https://en.bem.info/methodology/naming-convention/

  Keep up the momentum!

  1

  ---

  

  Nebiyou Ersabo•185

  @NebiyouErsaboPosted over 3 years ago

  @ericsalvi Thank you for the feedback!

  0

  

  Eric Salvi•1,350

  @ericsalviPosted over 3 years ago

  @Nebiyou12 I meant to also mention that you should give the mobile-first approach a try. I never did that and always struggled to design on mobile-first then trying to override styles and classes for mobile. It was a pain. If you design on mobile-first, you set min-width break points and you notice that you need less CSS for the desktop version versus the other way around.

  1
• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Hi

  I think you need to remove all the brs from this. Use margins for vertical spacing instead,this is not what brs are for

  0

  ---

  

  Nebiyou Ersabo•185

  @NebiyouErsaboPosted over 3 years ago

  @grace-snow oh yes, I know. I was just looking for a quick fix 😂, using those helped a little with the spacings. When I used margins & paddings it messed everything up. Also, I haven't heard about vertical spacing, I guess I'll look more into it. Thank you!

  0

  

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  @Nebiyou12 I just mean use margin to space stuff above and below instead of brs

  0