CSS Flexbox QR-Code response card

Community feedback

• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi,

  Congrats on submitting your first solution for the challenge

  Just a few small suggestions. instead of a percentage for the width of the card maybe use max-width: 350px; you can adjust the width as need. Also very important remove the height from the card it causes text to overflow

  and lastly instead of adding min-height: 90vh on the body add the following on the main tag center the child elements.

  main {
      position: relative;
      height: inherit;
      display: flex;
      justify-content: center;
      align-items: center;
      min-height: 100%;
  }
  

  Hope that helps, let me know if you have any other questions

  Marked as helpful

  2

  ---

  

  Marko•80

  @smarko-webPosted about 2 years ago

  @hyrongennike Thank you for your feedback, I did the improvements that were recommended.

  Another concern that popped up when I was sharing this 'project', is when you open this site on mobile, using different browsers, each of them renders the project uniquely. How would I resolve this issue(should I be overly concerned as a beginner)?

  0