Skip to content
Submitted about 1 year ago

CSS Flex-box

daniDev6•150
@daniDev6
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I would like to receive feedback on how I did the challenge.

Community feedback

  • Juan Ramirez•170
    @JuanRamirez2000Posted about 1 year ago

    Nice job!

    Everything seems fine, the only thing I would suggest is maybe changing the naming of some of your css class names. I noticed you have ".card-image" referencing the container for the image. This is fine, but it might lead to confusion somewhere down the line. Maybe changing it to ".card-image-container" and referencing the image itself by ".card-image-container > img" would be more readable.

    Marked as helpful
    0
    daniDev6•150
    @daniDev6Posted about 1 year ago

    @JuanRamirez2000 Thanks for the comment, update the code and I will take it into account in future projects.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord