Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Css Flexbox

Emad Jaber• 130

@emad2411

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


looking forward for your feedback and advice.

Community feedback

P
Patrick• 14,285

@palgramming

Posted

  1. you are currently missing your border radius on your layout
  2. you currently have cards wrapping into two rows when the browser windows is about 1140px wide. So you need to work on your transitions point between desktop and mobile

Marked as helpful

0

Emad Jaber• 130

@emad2411

Posted

@palgramming Thanks Patrick ! very helpful

0
Vanza Setia• 27,795

@vanzasetia

Posted

👋Hi Emad Jaber! My name is Vanza!

I have some feedbacks to help you improve this solution:

  • The background-color should be very light gray, since that's how it is on the design.
  • The content should be on the center of the page, to achieve that you can try this:
body {
  display: flex;
  align-items: center;
  justify-content: center;
  min-height: 100vh;
}
  • flex-wrap: wrap on .container cause an issue when only 2 cards that can fit on a row, try to fix that by adding more media queries.

That's it! Hopefully this is helpful!

Marked as helpful

0

Emad Jaber• 130

@emad2411

Posted

@vanzasetia Thanks for the feedback . I made the changes I hope you take another look.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord