Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

3-column-preview-card-component

Khazar 50

@Xezer669

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I'm not sure about the mobile and desktop versions

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HEADINGS ⚠️:

  • This solution consists incorrect usage of <h1> so it can cause severe accessibility errors due to incorrect usage of level-one headings <h1>
  • Every site must want only one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • In this solution there's three <h1> elements, like this <h1>SEDANS</h1>, you can preferably use <h2> instead of <h1>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely
  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)
  • Example: <h1 class="sr-only">3-column preview card component</h1>
  • If you have any questions or need further clarification, you can always check out my submission for this challenge where i used this technique and feel free to reach out to me.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

Khazar 50

@Xezer669

Posted

@0xAbdulKhalid I forgot this. Thanks for reminding me. I will made it now. Also, there is still a problem with my mobile view. it's good if you look.

0
P

@bhoamikhona

Posted

Use justify-content: center and align-items: center on the container and make the body height: 100vh to perfectly center the component on the web-page instead of trying to use padding to center it.

Moreover, move the media query to the bottom of the CSS file. This is because, the CSS file is read from top to bottom. So, it is not properly picking it up.

The border-radius in-between two cards should be removed. It should only exist in the outermost border of the component.

Here is my solution to this, if it helps: My Solution

Marked as helpful

0

Khazar 50

@Xezer669

Posted

@bhoamikhona Thank you very much, I have read your comment and understood it completely, now I will correct it again, you can watch it again as soon as possible. Thank you very much for your support.

0
Khazar 50

@Xezer669

Posted

@bhoamikhona i couldn't do that The border-radius in-between two cards should be removed. It should only exist in the outermost border of the component.

0
P

@bhoamikhona

Posted

@Xezer669

You do not need

<main>
<section class="container">
<section></section>
<section></section>
<section></section>
</section>
</main>

This should work:

<main class="container">
<section></section>
<section></section>
<section></section>
</main>

To specifically round a particular corner, you can use the following properties: border-top-right-radius: 10px border-top-left-radius: 10px

border-bottom-right-radius: 10px border-bottom-left-radius: 10px

Use these properties to round a particular corner.

Marked as helpful

0
Khazar 50

@Xezer669

Posted

@bhoamikhona thank you for your support. I am understand you. I will made this now.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord