CSS Flexbox

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Hi Badem,

  I'm viewing on mobile and loads of content is overlapping for me. You'll probably see it if you emulate a small phone like iPhone 5.

  I think it's because you're setting explicit heights on things in viewport units. You shouldn't have to set heights on anything at all in this challenge, except maybe a min-height of 100vh on the body/section elements. I think you'd be safe to remove them.

  The other thing you can remove is all the alt="star" and change to alt="". At the moment, screenreaders would read out ever image like "image, star, image, star, image, star..." which makes for a really bad experience. Leaving the alt tag empty intentionally will tell assistive tech it can safely ignore those images.

  I hope that's helpful advice for your learning. Please upvote the comment if it's helpful so I know for next time, thanks

  1

  ---

  

  Mehmet•285

  @memsbdmPosted almost 4 years ago

  @grace-snow thank you for your feedback I didn't know that ! I will try to apply your advices for my future works :)

  0