CSS Flexbox, HTML, CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  QR iMAGE ALT TEXT 📸:

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute.

  ---

  • The alt attribute should explain the purpose of the image.

  ---

  • E.g. alt="QR code to frontendmentor.io"

  ---

  <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  P

  RogelioCamargo•200

  @RogelioCamargoPosted over 1 year ago

  Your solution is awesome and looks great on all devices.

  What I noticed:

  1. Font is incorrect. In case you don't know how to use Google fonts, this is a good resource: How to use Google Fonts
  2. Use "min-height: 100vh" for body instead of "height: 100vh." Setting the height: 100vh may result in the component being cut off on smaller screens.

  0