Design comparison
Solution retrospective
Howdy y'all, This is my 7th newbie challenge. I used a mobile first approach but had a really tough time rescaling it to desktop version. The live site is slightly different that the design screenshot so check it out.
The issue I wasn't able to solve was that the social icons on phone look very cluttered. Although they look decently spaced out on dev tools, that is not the case when I open it on my iphone. No clue how to solve this one. Perhaps it has something to do the method i used for the border-lines of the socials and how I centered them.
Apart from that any suggestions, comments, shortcuts are very welcome!
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hello there, Nebiyou Ersabo! π
Nice job on this challenge! π Your solution looks good and is responsive! π
That's an interesting issue you have with the alignment of the social media icons (since they look fine on my screen and in the dev tools to me, as well). π
I noticed that you have
overflow: hidden
on thebody
in the desktop layout. I suggest removing that because that means that users can no longer scroll and will not be able to view or reach all of the content of the page if they are viewing your site on a screen with a smaller height. If the reason you added that rule was to prevent horizontal scrolling, useoverflow-x: hidden
instead so that users can still scroll up/down. πHope that small tip helps. π
Keep coding (and happy coding, too)! π
0@NebiyouErsaboPosted over 3 years ago@ApplePieGiraffe Thanks for viewing my solution, the legend APGπ. oh yea, I added that because there was an excessive space below the footer when you scroll. I thought that i could fix it by limiting the scroll with
overflow:hidden
. Is there a way to make the footer just stick to bottom of page while still making it scrollable? Thanks for the tips!1@ApplePieGiraffePosted over 3 years ago@Nebiyou12
Haha, glad to help! π
If you allow the height of the header and footer to be determined by the their content (e.g., the logo and the social media icons inside them, respectively), you could let the middle section fill up the remaining space. You could try adding
min-height: 100vh
to thebody
to ensure that it's always at least as high as the viewport and maybe something likeheight: 100%
on the middle section to get it to fill up the remaining height of its container. It might take a little playing around with to get right. π1@NebiyouErsaboPosted over 3 years ago@ApplePieGiraffe Cool will experiment with that a bit.
Not that it matters to the solution, but I was wondering how long did it take you to learn frontend programming? Also what are you currently doing here in UG?
1@ApplePieGiraffePosted over 3 years ago@Nebiyou12
Hey!
Sorry for the late replyβI didn't see this until now. π I've been learning frontend development on Frontend Mentor for a little less than a year, now. And I actually live here in UG with my family (and have been for quite a while)! π
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord