CSS Flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 7 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  QR iMAGE ALT TEXT 📸:

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute.

  ---

  • The alt attribute should explain the purpose of the image.

  ---

  • E.g. alt="QR code to frontendmentor.io"

  ---

  <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Bernardo Poggioni•5,360

  @R3ygoskiPosted 7 months ago

  Hello Juan, congratulations on completing your project, it turned out very well, and almost similar to the design, which is great, congratulations!

  I would like to give you some tips, the first one is related to your CSS. I noticed that you used the unit of measurement px for font size, which is not wrong, but I strongly recommend that you use rem instead, because rem is relative and adapts to the user's font settings, which greatly helps the accessibility of your project.

  Another tip is related to HTML. I noticed that it has a good structure, but it lacks semantic meaning, and this semantic part is important not only for SEO, but also for accessibility. I'll show you the sections that can be changed to increase semantics:

  • <div class="card__content"> can be changed to <main>, because this is where the main content of the page is.
  • <div class="content__text"> can be changed to <section>, because the content here is of the same theme, related to each other, and depends on the overall context of the page.

  Again, congratulations on your project, it turned out very well, keep practicing and improving. If you have any questions, please comment below and I will try to help in the best possible way.

  Marked as helpful

  0
• 

  IsASecret•40

  @IsASecretPosted 7 months ago

  Looks good, works on lots of different devices.

  0