Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

CSS Flexbox

@DarkKiller31

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I consider that being more organized with the documentation file

What challenges did you encounter, and how did you overcome them?

none is a very easy exercise to understand and solve

What specific areas of your project would you like help with?

in none

Community feedback

Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have a suggestion regarding your code that I believe will be of great interest to you.

QR iMAGE ALT TEXT πŸ“Έ:

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute.
  • The alt attribute should explain the purpose of the image.
  • E.g. alt="QR code to frontendmentor.io"
<img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0
Bernardo Poggioniβ€’ 5,140

@R3ygoski

Posted

Hello Juan, congratulations on completing your project, it turned out very well, and almost similar to the design, which is great, congratulations!

I would like to give you some tips, the first one is related to your CSS. I noticed that you used the unit of measurement px for font size, which is not wrong, but I strongly recommend that you use rem instead, because rem is relative and adapts to the user's font settings, which greatly helps the accessibility of your project.

Another tip is related to HTML. I noticed that it has a good structure, but it lacks semantic meaning, and this semantic part is important not only for SEO, but also for accessibility. I'll show you the sections that can be changed to increase semantics:

  • <div class="card__content"> can be changed to <main>, because this is where the main content of the page is.
  • <div class="content__text"> can be changed to <section>, because the content here is of the same theme, related to each other, and depends on the overall context of the page.

Again, congratulations on your project, it turned out very well, keep practicing and improving. If you have any questions, please comment below and I will try to help in the best possible way.

Marked as helpful

0
IsASecretβ€’ 40

@IsASecret

Posted

Looks good, works on lots of different devices.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord