CSS flexbox, CSS media queries, CSS in html document
Design comparison
Solution retrospective
The challenge difficult is very easy, i dont know if i need to create css file to separate the styles
Community feedback
- @correlucasPosted about 2 years ago
👾Hi Arturo Muñoz, congratulations for your first solution!
Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:
Something I've noticed in your code is that in many occasions you've added some
<div>
to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be<div>
or<main>
if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:<body> <main> <img src="./images/image-qr-code.png" alt="Qr Code Image" > <h1>Improve your front-end skills by building projects</h1> <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </main> </body>
✌️ I hope this helps you and happy coding!
Marked as helpful0@artuino0Posted about 2 years ago@correlucas perfect, i really appreciate your feedback, i'll try to manage this semitic structure in my next challenges, thank so much. let's coding!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord