CSS Flexbox (and a bit of grid)

Community feedback

• 

  David Payne•1,205

  @dpayne713Posted almost 4 years ago

  Mehmet,

  Nice Job! Looks nice - That's a big project .

  Couple of things to add some polish to the project:

  • In desktop sizes the header image isn't going across the entire viewport.
  • Some 'hover' states would be great on some of the buttons. The links in the footer also don't have cursor: pointer or a hover state to give feedback to the user that they can click on something.
  • in mobile sizes the 'quick search' 'iCloud link' etc text section has some placement issues. currently the paragraph elements are text align center but their container is to the far right of the screen.

  Hope this helps a bit, Keep it up!

  David

  2

  ---

  

  Mehmet•285

  @memsbdmPosted almost 4 years ago

  @dpayne713 maybe a background-size:cover can correct this (I didn't used it because it changed all backgrounds but I can do it on a mediaqueries for min-width:1441)

  That's true I just did it quickly I didn't optimized all :)

  I corrected the last problem thank you for your feedback !

  0
• 

  Mehmet•285

  @memsbdmPosted almost 4 years ago

  corrected display on git, try https://corrected-clip.vercel.app if you have a display problem on your device please comment !

  0