Skip to content
Submitted over 1 year ago

css flexbox

KOUZ•20
@kouzgr
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

All feeback is welcome thank you! ;D

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage
    • So fix it by replacing the <div class="box"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.
    • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>
    • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

    CSS 🎨:

    • We need to do some optimization on your css file
    • Add padding of 15px for <div class="box"> and for <body> change the height from 700px to min-height: 100vh

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    1
    KOUZ•20
    @kouzgrPosted over 1 year ago

    @0xAbdulKhalid fixed the problems you mentioned.Thank you very much! i would like too ask you what should i practice next. Like make the projects 2 times and use and css gidbox and css flexbox ?

    0
  • Marcel Dittmann•30
    @LenboxxiPosted over 1 year ago

    Maybe you could add to your box a padding to get the white border from the challenge, everything else looks fine. :)

    Marked as helpful
    1
    KOUZ•20
    @kouzgrPosted over 1 year ago

    @Lenboxxi thanks!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord