Skip to content
Submitted about 2 years ago

CSS flexbox

Fred Banda•10
@fredbanda
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Learning would to learn more bout css

Community feedback

  • Adriano•38,080
    @AdrianoEscarabotePosted about 2 years ago

    Hi Fred Banda, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    The rest is great!!

    Hope it helps...👍

    Marked as helpful
    0
    Fred Banda•10
    @fredbandaPosted about 2 years ago

    @AdrianoEscarabote Thank you it will hep

    0
  • Hyron•5,870
    @hyrongennikePosted about 2 years ago

    Hi @fredbanda,

    Congrats on completing the challenge

    To center the card you can add min-height: 100vh; on the body as well as text-align: center;

    Also check the report above and fix the accessibility issues.

    Hope this is helpful

    Marked as helpful
    0
    Fred Banda•10
    @fredbandaPosted about 2 years ago

    @hyrongennike Thank you so much will do that

    0
  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hello @fredbanda, Congratulations on completing this challenge!

    Here is some tips for you:

    1.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

    2.Replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in level of importance, never jump a level.

    2.Something I've noticed in your code is that in many occasions you've added some <div> to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be <div> or <main> if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    0
    Fred Banda•10
    @fredbandaPosted about 2 years ago

    @correlucas Thank you so much it will help learning is about trying new things

    1
    Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    @fredbanda This is nice Fred, say me if its was useful for you and if improved your code! Keep it up =)

    Marked as helpful
    0
    Fred Banda•10
    @fredbandaPosted about 2 years ago

    @correlucas Thank you I really need all the help I can get. Will upload the updated one incorporating the suggestions

    Thanks

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord