CSS flexbox

Community feedback

• 

  Ken Zimny•200

  @K-ZimnyPosted about 2 years ago

  You should remove the fixed height you have on the .card_styles classes. This can be an issue if the content becomes longer, as it will cause a text overflow.

  Instead, remove the height and apply align-items to the .wrapper_container.

  This will create a dynamic box no matter how the content gets updated (future proofing)

  Marked as helpful

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @Kishp73, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  You made your html structure entirely with div blocks but these div doesn't any semantic meaning, for this reason is better you use a better html markup improving your code, for example for each vehicle card you use <article> instead of the <div>.

  Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.

  To save your time you can code your whole page using px and then in the end use a VsCode plugin called px to rem here's the link → https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

  ✌️ I hope this helps you and happy coding!

  0