@vanzasetia
Posted
Hi, Mariana! 👋
It is fine if the card's width is having a bit more width or less width than the original design. It is more important to focus on code quality instead.
Alternative text for the QR code should be human-readable. Also, it should describe about the QR code used for. So, a better alternative text can be "QR code to frontendmentor.io".
Remove width
and height
from the <body>
. It should always fill the entire page. Treat it as the main element of the web page.
If you ever need to set a height on the <body>
, use min-height
instead. It is okay to always set min-height: 100vh
as the initial styling for the <body>
.
Avoid using px
unit for font sizes. Use rem
or em
instead. Relative units such as rem
and em
can adapt when the users change the browser's font size setting. Learn more — The Surprising Truth About Pixels and Accessibility: should I use pixels or rems?.
I hope this helps. Happy coding!
Marked as helpful
@marianarainha
Posted
@vanzasetia thank you very much !
@vanzasetia
Posted
@marianarainha You are welcome! I am glad I could help.