CSS, Flex

Community feedback

• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • You should use <main class="container"> instead of <div class="container">.
  • Go down orderly when you are using the headings h1 down to h2 down to h3 and so on. .

  This should fix most of your accessibility issues

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  Marked as helpful

  1
• 

  Roberto Yukio Miyamoto Arita•320

  @RyukioMiyamotoPosted over 2 years ago

  Great work! I just see some room for improvements regarding the buttons:

  • Font is not applying, what I found was just a typo:

  line 126 font-family: "Lexa Deca";
  

  • You could make your code more DRY by applying the hover effect on the btn class instead of individually. It would look like this:

  .btn:hover {
    background-color: transparent;
    color: var(--color-transparent-white);
  }
  

  Also, I would suggest you add the border to the btn class and just change the background color and color on hover, because, since the border wasn't there before, the button would "jump" (even though it's just 1 pixel).

  Hope you find this helpful! Good coding.

  Marked as helpful

  0