@Rhinozer0s
Posted
Hi @ELU,
your solution looks great! I have some recommendations for you.
Centering
You should remove the width, margin and padding of your <body>
. The body should always be on width: 100%
(which is the standard for block-elements). Use this to center your main-section:
body{
display: grid;
place-content: center;}
Aspect-ratio
Instead of setting a width and a heigh´t, you could use use aspect-ratio
property. Use this in combination with the width of your element and the height will always increase proportionally.
width: 200px;
aspect-ratio: 1 / 1;
In addition your sould use responsive untis like rem or em for building your website. Here you can read more about css units: https://www.w3schools.com/css/css_units.asp
i hope you find this helpfull 🤝
Marked as helpful
@ciberelu
Posted
@Rhinozer0s thanks for the recomendation i am going to do the changes