Design comparison
Solution retrospective
Henlo, I guess now I've got a hint of what responsiveness is. But there are still some inadequacies as you can see. Like ,my image is not fully occupying flexbox, and in smaller viewports my font doesn't seem to completely match with design we were provided with. Apart form all that , I don't think I'm lacking anywhere else, but please feel free to comment on my project if you feel there is some scope of improvement.
Community feedback
- @frank-itachiPosted over 1 year ago
Hello there 👋. You did a good job!
I have some suggestions about your code that might interest you.
HTML 📄:
- Wrap the page's whole main content in the
<main>tag. - If your code has different sections that have a specific like a , , sections or footer, it’s a good practice to enclose those parts with HTML5 landmarks.
For example, you could use a
<footer>tag to wrap a footer section. - Since the mobile design has a different image, you can use the
<picture>tag that allows you to interchange the images depending of the viewport size. Red more about this awesome tag here - Make sure that the
<img>elements in your HTML code has an alternate (descriptive text) short text. The reason for this is that screen readers can’t translate images into text. So to fix this you can do the following<img src=”…” alt=”short text” >
I hope you find it useful! 😁😁 Above all, the solution you submitted is great👌!
Happy
<coding />😎!Marked as helpful0@kabir-afkPosted over 1 year ago@frank-itachi Well I think I'll look up the picture tag since I was unaware of it
0 - Wrap the page's whole main content in the
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord